Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Wall and -Wunused-packages in fourmolu and ormolu plugins #4007

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented Jan 23, 2024

No description provided.

where
conf = def{plcConfig = (\(Object obj) -> obj) $ object ["external" .= cli]}
conf = def{plcConfig = KM.fromList ["external" .= cli]}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that conf was unused was actual test bug - the tests only ever executed with the default configuration (only def was passed to goldenWithHaskellDocFormatter).

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Jan 23, 2024
@mergify mergify bot merged commit d6553e0 into haskell:master Jan 23, 2024
42 checks passed
@jhrcek jhrcek deleted the jhrcek/unused-packages-ormolu-fourmolu branch January 23, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants