Fix -Wunused-imports #4037
Merged
Fix -Wunused-imports #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
requested review from
soulomoon,
pepeiborra,
santiweight and
eddiemundo
as code owners
jhrcek
commented
Feb 3, 2024
| @@ -4,8 +4,7 @@ | |||
| {-# LANGUAGE RecordWildCards #-} | |||
| {-# LANGUAGE ViewPatterns #-} | |||
|
|
|||
| {-# OPTIONS_GHC -Wall -Wwarn -fno-warn-type-defaults #-} | |||
| {-# OPTIONS_GHC -Wno-name-shadowing #-} | |||
| {-# OPTIONS_GHC -Wwarn -fno-warn-type-defaults #-} | |||
There was a problem hiding this comment.
Removing per-file warnings flags that are enabled for all plugins universally via import warnings in haskell-language-server.cabal
jhrcek
force-pushed
the
jhrcek/fix-unused-imports
branch
2 times, most recently
from
07bf4bb
to
e4743f9
Compare
jhrcek
force-pushed
the
jhrcek/fix-unused-imports
branch
from
e4743f9
to
a149fc9
Compare
|
FWIW I wonder if you want to still go per-component, then you can also start including the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since -Wall was turned on more universally during recent cabal file consolidations, the build logs are very noisy.
I'd like to fix most of the warnings, doing focused changes per PR to make it easy to review.