Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document symbols unit tests. #655

Merged

Conversation

peterwicksstringfield
Copy link
Contributor

Actually I had to leave several of these tests disabled because it seems HLS can't extract as many symbols as HIE could. But the disabled tests are at least documented more clearly now.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great follow up, many thanks!
Will merge when ci is green

@jneira jneira merged commit f260c29 into haskell:master Dec 9, 2020
@peterwicksstringfield peterwicksstringfield deleted the enable_document_symbols_tests branch December 9, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants