Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get building with ghc-8.10 #83

Merged
merged 4 commits into from
May 6, 2020
Merged

Get building with ghc-8.10 #83

merged 4 commits into from
May 6, 2020

Conversation

lukel97
Copy link
Collaborator

@lukel97 lukel97 commented May 3, 2020

@alanz @fendor I think we can create a new release of haskell-lsp with updated bounds before merging this, to avoid extra submodules?
Also the mpickering hie-bios fork should have the changes from the fendor fork now

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Do you need to update the stack*.yaml files as well, so that everything is using the same versions?

@lukel97
Copy link
Collaborator Author

lukel97 commented May 5, 2020

@fendor I think we might need to update ghcide first, I'm not sure if we can use allow-newer on a per package basis in a stack.yaml file

@lukel97 lukel97 marked this pull request as ready for review May 6, 2020 13:06
@lukel97 lukel97 requested a review from fendor May 6, 2020 13:06
@lukel97
Copy link
Collaborator Author

lukel97 commented May 6, 2020

Just realised that there's no stackage snapshot for ghc 8.10 yet, so it doesn't matter. Updated the stack files

@fendor
Copy link
Collaborator

fendor commented May 6, 2020

CI needs still updates right?

@lukel97
Copy link
Collaborator Author

lukel97 commented May 6, 2020

Like update the cabal circleCI job?

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merge when CI is "greenish", e.g. no build failure

@lukel97
Copy link
Collaborator Author

lukel97 commented May 6, 2020

Looks like there's no docker image for 8.10 yet either :(

This reverts commit 221e006.
There's no docker image available yet
@lukel97 lukel97 merged commit 6ddefac into master May 6, 2020
@lukel97 lukel97 deleted the ghc-8.10 branch July 23, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants