Cosmetic changes in ‘haskel-indentation.el’ #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also note about commit message: please do not put TODO items there, make a new issue in github instead. |
Various cosmetic corrections. All the changes do not introduce any differences in functioning of the module, this is just refactoring. I've written doc-strings where possible. Many functions still need decent doc-strings, I've marked them with FIXME. It's possible that I'll add doc-string of these functions later. N.B. the module is quite hairy, so you should have really good doc-strings here.
|
@gracjan, Are |
mrkkrp
force-pushed
the
indentation-cosmetics
branch
from
f631ba8
to
03cc844
Compare
|
@gracjan, Done, uppercased |
|
I do not mind TODOs in the files although it is a bit of a double booking. Issues is where we keep track of work to be done. |
gracjan
added a commit
that referenced
this pull request
Aug 14, 2015
Cosmetic changes in ‘haskel-indentation.el’
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various cosmetic corrections. All the changes do not introduce any
differences in functioning of the module, this is just refactoring.
Added TODO items:
version
I've written doc-strings where possible. Many functions still need
decent doc-strings, I've marked them with FIXME. It's possible that I'll
add doc-string of these functions later. N.B. the module is quite hairy,
so you should have really good doc-strings here.