-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate testing/Main.hs to Tasty testing framework #8
Conversation
The only frustrating problem with compare e.g. http://matrix.hackage.haskell.org/package/tasty vs. http://matrix.hackage.haskell.org/package/test-framework Personally, I tend to avoid using |
Oh, I didn't know that tasty doesn't support GHC <7.4 and that Hoopl does. I'll change the PR to use test-framework. Thanks! |
This is (hopefully) a first step to cleaning up and extending Hoopl's testsuite. In the future I'd like to add some QuickCheck tests, so I wanted to use a testing framework that would make it easy to handle both HUnit and QuickCheck tests. Note that we considered using tasty (instead of test-framework), but it doesn't support GHC <7.4, which Hoopl does support.
Moved to test-framework. |
How much that problem does really affect the users in the wild? There have been three stable releases since GHC 7.4. And with |
@jstolarek this affects mostly the TravisCI build; if you go w/ |
Travis build of GHC, I presume? I treat Hoopl as a Haskell library and as such it shouldn't be a major problem to drop support for very old versions of GHC. But at the moment I don't see how this affects GHC in any way - older versions of GHC were released with older versions of Hoopl and obviously these won't be affected. |
No, the Travis build of (If it wasn't clear from my comments, I'm considering |
Oh, that. I personally wouldn't have any problems with dropping support for these old GHC versions, but that's not for me to decide. Perhaps we can use test-framework for now and if it gives us problems then consider switching to tasty? |
I used QuickCheck without depending on tasty. Let's add more tests first then we can debate whether it's worth adding more dependency to hoopl. I prefer to keeping the dependency of hoopl to the minimum. |
merged |
Hoopl's testsuite seems to be pretty tiny (8 goldens tests). So this is basically a first step in extending it. Since I'd also like to add some QuickCheck tests, I went with using Tasty - this should make it easy to add both new goldens or unit test as well as QuickCheck ones.