Skip to content

Conversation

konsumlamm
Copy link
Collaborator

Closes #32.

Fix the documentation of dot and mention <=< as a more intuitive alternative. Also add a proof for the associativity of dot.

cc @Borgvall @treeowl

Copy link
Contributor

@Borgvall Borgvall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some parts this PR has the same issues as treeowls variant.

@konsumlamm konsumlamm changed the title Fix dot documentation v2 Deprecate dot Apr 24, 2025
@konsumlamm
Copy link
Collaborator Author

Given that r0 `dot` strat has even more confusing behaviour than I thought, I think it's best to simply deprecate dot.

@konsumlamm konsumlamm requested a review from Borgvall April 27, 2025 14:40
Copy link
Contributor

@Borgvall Borgvall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments about misleading documentation of dot are resolved, now. In addition dot has been deprecated, which I approve.

--
-- Perhaps unexpectedly, @r0 `dot` strat == r0@.
-- 'Control.Monad.<=<' has a more intuitive behaviour (@r0 <=< strat == strat@).
{-# DEPRECATED dot "'dot' is an unintuitive composition operator. Use 'Control.Monad.<=<` instead." #-}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus one for deprecating dot.

@konsumlamm konsumlamm merged commit 489e8d9 into haskell:master May 3, 2025
13 checks passed
@konsumlamm konsumlamm deleted the dot branch May 3, 2025 20:06
konsumlamm added a commit to treeowl/parallel that referenced this pull request May 20, 2025
* Fix dot documentation

* Deprecate `dot`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants