-
Notifications
You must be signed in to change notification settings - Fork 24
Deprecate dot #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate dot #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some parts this PR has the same issues as treeowls variant.
Given that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments about misleading documentation of dot
are resolved, now. In addition dot
has been deprecated, which I approve.
-- | ||
-- Perhaps unexpectedly, @r0 `dot` strat == r0@. | ||
-- 'Control.Monad.<=<' has a more intuitive behaviour (@r0 <=< strat == strat@). | ||
{-# DEPRECATED dot "'dot' is an unintuitive composition operator. Use 'Control.Monad.<=<` instead." #-} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus one for deprecating dot.
* Fix dot documentation * Deprecate `dot`
Closes #32.
Fix the documentation of
dot
and mention<=<
as a more intuitive alternative. Also add a proof for the associativity ofdot
.cc @Borgvall @treeowl