Skip to content

Conversation

imuli
Copy link
Contributor

@imuli imuli commented Nov 27, 2020

  • also don't remove context from data declarations

Fixes: #339

@EncodePanda
Copy link
Contributor

@jaspervdj I don't seem to have the rights to re-run the CI, could you possibly do that?

@EncodePanda
Copy link
Contributor

@imuli do you want to pair up to push this PR forward?

@imuli
Copy link
Contributor Author

imuli commented Apr 10, 2021

I have limited personal bandwith at the moment, but I will attempt to find some. I can at least rebase onto the current main branch if that's helpful.

@imuli
Copy link
Contributor Author

imuli commented Apr 10, 2021

Looks like the CI on macOS is still having problems.

@EncodePanda
Copy link
Contributor

I've just fixed mac cache. Can you rerun?

@EncodePanda
Copy link
Contributor

By rerun I mean rebase one more time, please :)

- also don't remove context from data declarations
@imuli imuli force-pushed the data-existential-quantification branch from 3335eaf to 3a15320 Compare April 10, 2021 23:56
@cdornan
Copy link

cdornan commented Apr 23, 2021

It would be awesome if we could get this patch released.

@EncodePanda
Copy link
Contributor

@cdornan I've bumped the CI so the tests are passing now. I will evaluate the PR over the weekend and if all is good we will get it in.

@EncodePanda
Copy link
Contributor

@imuli could we add

case60 :: Assertion
case60 = assertSnippet (step defaultConfig)
    [ "data Foo = forall a . Bar a" ]
    [ "data Foo = forall a. Bar a" ]

for completeness?


-- | Don't remove existential quantification
--
-- See https://github.com/jaspervdj/stylish-haskell/issues/339
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EncodePanda EncodePanda self-requested a review April 23, 2021 08:49
Copy link
Contributor

@EncodePanda EncodePanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imuli this is amazing work! thank you so much for the contribution!

Please add the missing test case60 (just copy-paste from the comment) and update the link to the issue in the comment.

One more time, thank so much for this :)

Copy link
Contributor

@EncodePanda EncodePanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@EncodePanda EncodePanda merged commit 4cbefb8 into haskell:main Apr 23, 2021
@imuli imuli deleted the data-existential-quantification branch April 28, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Existential quantification disappears in type declarations after applying stylish-haskell

3 participants