-
Notifications
You must be signed in to change notification settings - Fork 153
Don't remove existential quantification (#339) #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't remove existential quantification (#339) #344
Conversation
@jaspervdj I don't seem to have the rights to re-run the CI, could you possibly do that? |
@imuli do you want to pair up to push this PR forward? |
I have limited personal bandwith at the moment, but I will attempt to find some. I can at least rebase onto the current |
Looks like the CI on macOS is still having problems. |
I've just fixed mac cache. Can you rerun? |
By rerun I mean rebase one more time, please :) |
- also don't remove context from data declarations
3335eaf
to
3a15320
Compare
It would be awesome if we could get this patch released. |
@cdornan I've bumped the CI so the tests are passing now. I will evaluate the PR over the weekend and if all is good we will get it in. |
@imuli could we add
for completeness? |
|
||
-- | Don't remove existential quantification | ||
-- | ||
-- See https://github.com/jaspervdj/stylish-haskell/issues/339 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the comment to https://github.com/jaspervdj/haskell/issues/339
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imuli this is amazing work! thank you so much for the contribution!
Please add the missing test case60
(just copy-paste from the comment) and update the link to the issue in the comment.
One more time, thank so much for this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
Fixes: #339