Added Semigroup instances, in preparation for base 4.11 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvr
suggested changes
Sep 21, 2017
There was a problem hiding this comment.
Unfortunately this patch isn't -Wcompat clean. What I had planned for test-framework is to follow the recommended variant at
https://prime.haskell.org/wiki/Libraries/Proposals/SemigroupMonoid#Writingcompatiblecode
IOW, doing it w/o any CPP.
You can use this here as a starting point: https://github.com/hvr/head.hackage/blob/master/patches/test-framework-0.8.1.1.patch
Base 4.11 will have Semigroup as a superclass of Monoid ghc/ghc@8ae263c
ElvishJerricco
force-pushed
the
semigroup-instances
branch
from
6366861 to
af9b972
Compare
|
@hvr How's that? |
hvr
approved these changes
Sep 22, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base 4.11 will have Semigroup as a superclass of Monoid
ghc/ghc@8ae263c