Skip to content

derive Read, Show, Eq, and Ord instances for BaudRate #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

derive Read, Show, Eq, and Ord instances for BaudRate #191

wants to merge 2 commits into from

Conversation

dopamane
Copy link

@dopamane dopamane commented Jun 26, 2021 •
edited
Loading

Derive Read, Show, Eq, and Ord instances for BaudRate. It would be useful to have these instances for serialport.

@hs-viktor
Copy link
Contributor

I've already handled everything but Read in #216. How important is Read with symbolic rates? I think that the Num instance actually makes for a better UX, and the BaudRate constructor is now exposed.

Is #216 sufficient? I'm inclined to close this if it is...

@hasufell hasufell closed this Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dopamane @hs-viktor @hasufell