Consistently use throwErrnoPathIf*
#245
Conversation
|
CirrusCI fails during setup with I'd be quite surprised this is caused by this patch though 😄 |
|
I don't even know what CirrusCI is. |
|
WASI build fails because |
A CI environment running the tests on FreeBSD, from what I could gather. |
|
@TerrorJack could you please look at wasm build failures? |
|
I'll rebase once #246 is merged (which likely requires a fix for the WASI builds first, so rebase should fix that as well). |
|
(I'm working on a fix for the WASI build. Not sure how it could succeed in the past, though.) |
The `System.Posix.Files.PosixString` and `System.Posix.Temp.PosixString` modules failed to build on the WASI/WASM platform because foreign imports of `mkstemp` and `mknod` was not conditional on `configure` findings. This patch aligns these modules with their non-`PosixString` counterparts. See: haskell#245 See: https://github.com/haskell/unix/runs/8284652815?check_suite_focus=true
@TerrorJack, make sure to see #247 before jumping on this and potentially wasting valuable time 😉 |
The `System.Posix.Files.PosixString` and `System.Posix.Temp.PosixString` modules failed to build on the WASI/WASM platform because foreign imports of `mkstemp` and `mknod` was not conditional on `configure` findings. This patch aligns these modules with their non-`PosixString` counterparts. See: #245 See: https://github.com/haskell/unix/runs/8284652815?check_suite_focus=true
In some functions, a combination of `throwErrnoIf*` and `modifyIOError`/`ioeSetFileName` was used, even though `throwErrnoPathIf*` helpers are available. This patch cleans up such code, unifying the use of the `throwErrnoPathIf*` helpers.
NicolasT
force-pushed
the
throw-with-path
branch
from
7d76301 to
3b316f6
Compare
|
Thanks @NicolasT! |
In some functions, a combination of
throwErrnoIf*andmodifyIOError/ioeSetFileNamewas used, even thoughthrowErrnoPathIf*helpers are available.This patch cleans up such code, unifying the use of the
throwErrnoPathIf*helpers.