Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVector data instances are exposed from Unboxed and Unboxed.Mutable #492

Open
meooow25 opened this issue May 3, 2024 · 2 comments
Open

Comments

@meooow25
Copy link

meooow25 commented May 3, 2024

module Data.Vector.Unboxed (
-- * Unboxed vectors
Vector(V_UnboxAs, V_UnboxViaPrim), MVector(..), Unbox,

module Data.Vector.Unboxed.Mutable (
-- * Mutable vectors of primitive types
MVector(..), IOVector, STVector, Unbox,

I was confused as to why Vector data instances are not exposed but MVector instances are.

Then I found #49 (comment) which explains why exposing them is unsafe, which is fair. But then there is no reason to expose the MVector instances. This wasn't answered in #49.

I would expect this to consistent between Vector and MVector. Or perhaps this issue is known but the MVector instances are not hidden to avoid breakage?

@Shimuuar
Copy link
Contributor

Shimuuar commented May 3, 2024

Yes mutable vector were exposed early in the development for some reason. And yes hiding them is a breaking change

@meooow25
Copy link
Author

meooow25 commented May 3, 2024

Thanks, that answers the question! Please close this if there is nothing to be done about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants