-
Notifications
You must be signed in to change notification settings - Fork 141
Add monadic variants for iterateN, unfoldr, unfoldrN #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a starting point for writing tests would be some tiny examples and checking that the results are as expected |
Only property I can think of is that |
toy inputs plus results to make sure they're in the test suite will still be nice. just bog simple "heres an input and the expected result" level testing is better than no testing at all! ;) |
I've added tests for new functions and restored some commened out tests. Test suite does need some love. P.S. I think this shoudl fix #8 |
great, THANK YOU. (NB: i havent done a close reading of those tests to make sure they're good, I'm just expressing gratitude rather than indicating i've done any form of code review) |
Bump. I'm interested in this too! |
this is a nice PR, we're catching up on stuff, but will look at it in the next week or so. if you find some time to clean it it up for master please let me know, else happy to have a go myself :) |
Will do that |
test for unfoldrM is not used yet It required generalization of Arbitrary and TestData instances for Writer monad
I've rebased branch to the current master. |
Thanks! We'll review it soon! Awesome On Monday, July 25, 2016, Aleksey Khudyakov notifications@github.com
|
As this was apparently merged into master, has this ever been released? |
No, you you look at http://hackage.haskell.org/package/vector you'll see the upload date is earlier than the merge. |
I needed such functions while working on some toy Monte-Carlo simulations. It turned out that all required stream fusion machniery for these functions was present already but they weren't implemented for some reason
There're no tests. I don't really know what to test here.