Skip to content

Conversation

Shimuuar
Copy link
Contributor

I needed such functions while working on some toy Monte-Carlo simulations. It turned out that all required stream fusion machniery for these functions was present already but they weren't implemented for some reason

There're no tests. I don't really know what to test here.

@cartazio
Copy link
Contributor

a starting point for writing tests would be some tiny examples and checking that the results are as expected

@Shimuuar
Copy link
Contributor Author

Only property I can think of is that iterateM produces same results as iterate for identity monad. But that should be true by construction. It probably won't hurt t add such test but it wouldn't be of much help

@cartazio
Copy link
Contributor

toy inputs plus results to make sure they're in the test suite will still be nice. just bog simple "heres an input and the expected result" level testing is better than no testing at all! ;)

@Shimuuar
Copy link
Contributor Author

I've added tests for new functions and restored some commened out tests. Test suite does need some love.

P.S. I think this shoudl fix #8

@cartazio
Copy link
Contributor

great, THANK YOU.

(NB: i havent done a close reading of those tests to make sure they're good, I'm just expressing gratitude rather than indicating i've done any form of code review)

@Daniel-Diaz
Copy link

Bump. I'm interested in this too!

@cartazio
Copy link
Contributor

this is a nice PR, we're catching up on stuff, but will look at it in the next week or so. if you find some time to clean it it up for master please let me know, else happy to have a go myself :)

@Shimuuar
Copy link
Contributor Author

Will do that

@cartazio
Copy link
Contributor

yay :)
i may want some help de bit rotting the benchmark suite once @dolio finishes moving to the new style CI setup, at which point we could add this stuff to the benchmark suite.

@Shimuuar hope you dont mind that side diversion :0

@Shimuuar
Copy link
Contributor Author

I've rebased branch to the current master.

@cartazio
Copy link
Contributor

Thanks! We'll review it soon! Awesome

On Monday, July 25, 2016, Aleksey Khudyakov notifications@github.com
wrote:

I've rebased branch to the current master.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#41 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAQwj_GGxulSr6n1BMsE5mo9-DWhkS3ks5qZQR7gaJpZM4Cimwp
.

@dolio dolio merged commit 640b4c6 into haskell:master Jul 28, 2016
@fhaust
Copy link
Contributor

fhaust commented Sep 30, 2016

As this was apparently merged into master, has this ever been released?

@glguy
Copy link
Member

glguy commented Sep 30, 2016

No, you you look at http://hackage.haskell.org/package/vector you'll see the upload date is earlier than the merge.

@Shimuuar Shimuuar deleted the iterate-unfold branch October 31, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants