Update documentation for unboxed vector #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mention that vector are not _necessarily_ unboxed - Enumerate all standard deriving methods. (And drop "Implementing unboxed vectors for new data types can be very easy", it always felt like mockery.
lehins
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
I don't really see a need to remove NFData instance. In fact it would make sense to derive it for all newtypes in vector.
That being said, considering that DoNotUnboxNormalForm is only used for deriving and NFData is not necessary for that then I have a problem with removing it.
|
Largely removal is for consistence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop NFData instance for DoNotUnboxNormalForm since it's not needed
Revert accidental deletion of documentation in 89d7584
Rework overview of module for unboxed vectors
Mention that vector are not necessarily unboxed
Enumerate all standard deriving methods. (And drop "Implementing unboxed
vectors for new data types can be very easy", it always felt like mockery.