Add map for mutable vector which modify it in place. #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
reviewed
Sep 11, 2025
Shimuuar
force-pushed
the
mutable_mapM
branch
from
06943b5 to
0d3a6fd
Compare
Co-authored-by: Alexey Kuleshevich <lehins@yandex.ru>
Shimuuar
force-pushed
the
mutable_mapM
branch
from
9184bca to
367a037
Compare
|
I've added tests and specializations. PR is done I also disabled |
lehins
approved these changes
Sep 14, 2025
vector/vector.cabal
Outdated
Comment on lines
103
to
105
| -- Disable pointless warning about partial functions | ||
| if impl(ghc >= 9.8) | ||
| Ghc-Options: -Wno-x-partial |
There was a problem hiding this comment.
I'd suggest moving this to the test suite, where this is actually relevant, instead of also applying it to the library.
There was a problem hiding this comment.
Done. I consider this warning somewhat misguide so I'm fine with disabling it globally.
There was a problem hiding this comment.
I am actually very happy that this warning exists. IMHO, there is never a case when head or tail should be used outside of testing and throw away code
Shimuuar
force-pushed
the
mutable_mapM
branch
from
367a037 to
b2e00f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is last part of API for mutable vectors
Naming was discussed at length in #334. I somewhat arbitrarily picked variant with
InPlacesuffix. But I don't feel strongly about it and this is good moment for final decision. Bikeshedding season is onFixes #334