Skip to content

Add an option to set server command line arguments #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2021
Merged

Add an option to set server command line arguments #464

merged 1 commit into from
Sep 21, 2021

Conversation

cdsmith
Copy link
Contributor

@cdsmith cdsmith commented Sep 21, 2021

Fixes #462

@cdsmith
Copy link
Contributor Author

cdsmith commented Sep 21, 2021

This works. Unfortunately, it doesn't fix my problem because setting RTS command line options in haskell-language-server-wrapper doesn't pass them along to the version-specific haskell-language-server. However, we might as well get it in so that people can use it for other options (-d and so on)

jneira
jneira approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, many thanks, yeah it could be merged right now

@jneira jneira merged commit b9c5e97 into haskell:master Sep 21, 2021
@berberman berberman mentioned this pull request Sep 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing extra command line arguments to haskell-language-server
2 participants
@cdsmith @jneira