Skip to content

Relax base bounds for ghc-9.0.1 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2021
Merged

Relax base bounds for ghc-9.0.1 #39

merged 3 commits into from
Feb 19, 2021

Conversation

facundominguez
Copy link
Contributor

No description provided.

@facundominguez
Copy link
Contributor Author

Tests pass with ghc-9.0.1.

@asr asr mentioned this pull request Feb 7, 2021
Closed
19 tasks
@asr
Copy link

asr commented Feb 7, 2021

Blocking agda/agda#4955.

@emilypi
Copy link
Member

emilypi commented Feb 7, 2021 •
edited
Loading

@asr when CI is green, I'll merge this for you so we can get Agda unblocked.

@emilypi
Copy link
Member

emilypi commented Feb 7, 2021

@facundominguez i've fixed the conflicts in the latest commit to keep things moving. It looks like this PR requires a release of async and potentially a few other packages with GHC 9.0 support before we can merge this. This will be a few weeks or more to coordinate everything, but it's on my radar and we'll get it moving when we can.

@Bodigrim
Copy link
Contributor

It looks like this PR requires a release of async and potentially a few other packages with GHC 9.0 support before we can merge this.

@facundominguez could you please relax bounds to allow tasty-1.4? It does not depend on async, and everything compiles just fine with GHC 9.0, so we do not need to wait for anyone else.

@Bodigrim
Copy link
Contributor

@emilypi I think this is ready to go.

@Bodigrim
Copy link
Contributor

@emilypi ping

@emilypi
Copy link
Member

emilypi commented Feb 18, 2021

@Bodigrim yep, i hear you. I still don't have Hackage perms cc @dcoutts

@emilypi emilypi merged commit 07793d3 into haskell:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bodigrim Bodigrim Bodigrim approved these changes

+1 more reviewer

@emilypi emilypi emilypi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@facundominguez @asr @emilypi @Bodigrim