-
Notifications
You must be signed in to change notification settings - Fork 51
Feat/hakyll projects page migration #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/hakyll projects page migration #119
Conversation
@myShoggoth I'm not satisfied about my leaders solution but you may be interested to take a look 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great, a few small things.
link-text: https://gitlab.haskell.org/ghc/ghc | ||
subtitle: Project Leaders | ||
leader0name: Ben Gamari | ||
leader0img: /assets/images/project-leads/bg.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something I was not sure about was putting full image paths vs. knowing where they have to be for the context and just having the name. So:
leader0img: /assets/images/projectleads/bg.png
vs.
leader0img: bg.png
where the usage prepends the canonical path depending on the usage context. I went with the former but I think I'm leaning towards the latter. Not something we need to fix for this PR, just thought about it again while review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
problem with this is that some comes from "project-leads" and others come from "board-members" so it won't be only the name
leader0img: bg.png
leader1img: thc.png
vs
leader0img: project-leads/bg.png
leader1img: board-members/thc.png
We can image to separate the two properties :
leader0team: project-leads
leader0img: bg.png
leader1team: board-members
leader1img: thc.png
and to build it on use in project template project.html
<img src="$leader0team$/$leader0img$" alt="$leader0name$">
but it's maybe less straightforward than full path or team + name partial path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I let you look at the current proposal (compromise 😄) @myShoggoth
--- | ||
status: ideation | ||
title: GHC Performance Dashboards | ||
summary: The Haskell Foundation is working with the GHC team to help provide dashboard monitors for Haskell critical libraries (e.g. Aeson, Text, Bytestring). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we're not going to have stand alone pages then the 'summary' can be the body text, which would also allow us to style it if appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking from the opposite 😄
If we want dedicated pages about each projects : the current previews are generated from metadata and each detailed page will be from body.
I'm taking a look, I spotted a problem with contexts and body in this part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (if I had a good understanding of your wish 😉)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Topic : Migration for the projects page from hardcoded html to metadata in markdown.
Status : MVP / In Review
Steps :
Possible Improvements :