Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove methods #36

Merged
merged 3 commits into from
May 24, 2015
Merged

Add remove methods #36

merged 3 commits into from
May 24, 2015

Conversation

MPur
Copy link
Contributor

@MPur MPur commented Feb 25, 2015

Add has and remove methods to use Config easier
Add tests for method has and method remove
Add .idea to .gitignore for phpstorm's users

Add tests for method has and method remove
Add .idea to .gitignore for phpstorm's users
@hassankhan
Copy link
Owner

Hi, thanks for the pull request.

Personally I wouldn't add a remove() method, we've discussed this in the past and don't think it's within this library's scope.

That said, the has() method seems useful, thoughts @noodlehaus @DavidePastore?

@MPur
Copy link
Contributor Author

MPur commented Feb 25, 2015

I understand. For me, it's like offsetUnset of ArrayAccess.
What do you think If I change remove and i call it forget for example ?

@hassankhan
Copy link
Owner

To be completely honest, the only reason we have offsetUnset is so we can use ArrayAccess, changing the method name isn't the problem, it's just that we don't want to introduce that functionality at all for simplicity's sake.

Obviously if more people want this, then there's no problem 👍

@DavidePastore
Copy link
Collaborator

I agree with @hassankhan, I never had the need of the remove method. has could be really helpful.

Juste remove the remove method
@MPur
Copy link
Contributor Author

MPur commented Feb 26, 2015

Ok, I update and remove remove method.

Add comment for gitignore
@MPur MPur changed the title Add has and remove methods Add remove methods Apr 3, 2015
hassankhan added a commit that referenced this pull request May 24, 2015
@hassankhan hassankhan merged commit 46d43fb into hassankhan:develop May 24, 2015
@hassankhan
Copy link
Owner

Thanks for the PR!

@hassankhan hassankhan mentioned this pull request Mar 8, 2016
peter279k pushed a commit to open-source-contributions/config that referenced this pull request May 8, 2021
…it/phpunit-8.0.1

Bump phpunit/phpunit from 7.5.2 to 8.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants