Give YamlParser file content instead of path #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any specific reason why we should give the Yaml parser the contents of the file ourself? |
|
If you take a look in this file: https://github.com/symfony/Yaml/blob/master/Yaml.php at the parse method, you will see that it says: |
|
Ah right, didn't know that. Thanks!! |
hassankhan
added a commit
that referenced
this pull request
May 25, 2015
Give YamlParser file content instead of path
Closed
nochso
referenced
this pull request
in tomzx/php-semver-checker
Jan 23, 2016
…d is incompatible with ~3.0 (which phpunit would install).
peter279k
pushed a commit
to open-source-contributions/config
that referenced
this pull request
May 8, 2021
…it/phpunit-8.0.6 Bump phpunit/phpunit from 8.0.5 to 8.0.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.