Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
thresholds: "60 80"
- name: Add Coverage PR Comment
uses: marocchino/sticky-pull-request-comment@v2
if: ${{ github.event_name == 'pull_request' && github.repository == 'hasura/go-graphql-client' }}
if: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository }}
with:
path: code-coverage-results.md
- name: Dump docker logs on failure
Expand Down
15 changes: 7 additions & 8 deletions subscription_graphql_ws_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -576,14 +576,13 @@ func waitForConnectionState(t *testing.T, sc *SubscriptionClient, tickerDuration
defer ticker.Stop()

for {
select {
case <-ticker.C:
if checkFn() {
return true
}
if time.Now().After(deadline) {
return false
}
<-ticker.C
if checkFn() {
return true
}

if time.Now().After(deadline) {
return false
}
}
}
Expand Down