Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: add custom timeouts to actions #5762

Merged
merged 9 commits into from
Sep 16, 2020
Merged

server: add custom timeouts to actions #5762

merged 9 commits into from
Sep 16, 2020

Conversation

codingkarthik
Copy link
Contributor

@codingkarthik codingkarthik commented Sep 10, 2020 •
edited
Loading

fixes #4966 #5673

Description

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

@codingkarthik codingkarthik requested review from a team as code owners September 10, 2020 11:20
@netlify
Copy link

netlify bot commented Sep 10, 2020 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit c79e74e

https://deploy-preview-5762--hasura-docs.netlify.app

rakeshkky
rakeshkky approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@rakeshkky rakeshkky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server LGTM

tirumaraiselvan
tirumaraiselvan reviewed Sep 16, 2020
View reviewed changes
CHANGELOG.md Outdated
@@ -56,6 +56,7 @@ This release contains the [PDV refactor (#4111)](https://github.com/hasura/graph
- server: allow remote relationships joining `type` column with `[type]` input argument as spec allows this coercion (fixes #5133)
- server: add action-like URL templating for event triggers and remote schemas (fixes #2483)
- server: change `created_at` column type from `timestamp` to `timestamptz` for scheduled triggers tables (fix #5722)
- server: allow adding custom timeouts to actions (fixes #4966)
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan Sep 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow configuring timeouts for actions?

tirumaraiselvan
tirumaraiselvan approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@tirumaraiselvan tirumaraiselvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional changelog comment

@kodiakhq kodiakhq bot merged commit 9d047d1 into hasura:master Sep 16, 2020
@Naveenaidu Naveenaidu mentioned this pull request Sep 18, 2020
Closed
34 tasks
@tirumaraiselvan tirumaraiselvan added this to the v1.3.3 milestone Nov 3, 2020
codingkarthik added a commit to codingkarthik/graphql-engine that referenced this pull request Nov 6, 2020
@codingkarthik
server: add custom timeouts to actions (hasura#5762)
ca8b52f 
hasura#5762
@beerose beerose mentioned this pull request Nov 17, 2020
Closed
rikinsk pushed a commit that referenced this pull request Dec 16, 2020
@codingkarthik @rikinsk
server: add custom timeouts to actions (#5762)
4fa581d 
#5762
@Allymahmoud Allymahmoud mentioned this pull request Oct 10, 2024
Open
@Allymahmoud Allymahmoud mentioned this pull request Oct 10, 2024
Open
@sumodgeorge sumodgeorge mentioned this pull request Oct 10, 2024
Open
@Allymahmoud Allymahmoud mentioned this pull request Oct 11, 2024
Open
@sumodgeorge sumodgeorge mentioned this pull request Oct 12, 2024
Open
This was referenced Oct 14, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakeshkky rakeshkky rakeshkky approved these changes

@tirumaraiselvan tirumaraiselvan tirumaraiselvan approved these changes

@marionschleifer marionschleifer marionschleifer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.3
Development

Successfully merging this pull request may close these issues.

Configurable Async Action Timeout
4 participants
@codingkarthik @marionschleifer @tirumaraiselvan @rakeshkky