CDC class dcd_transdimension improvements #926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiFiPhile
changed the title
HiFiPhile
force-pushed
the
xfer_fifo_transdimension
branch
from
c6001f1
to
044823f
Compare
HiFiPhile
force-pushed
the
xfer_fifo_transdimension
branch
3 times, most recently
from
64e5551
to
d059aa9
Compare
HiFiPhile
force-pushed
the
xfer_fifo_transdimension
branch
from
d059aa9
to
9f8501b
Compare
Add ring buffer ON/OFF switch.
…le/tinyusb into xfer_fifo_transdimension
…le/tinyusb into xfer_fifo_transdimension
HiFiPhile
force-pushed
the
xfer_fifo_transdimension
branch
from
5c9ee3a
to
7ee24e0
Compare
|
I think I'll separate this PR into multiple parts for easier review:
|
|
yes, please do, separate the cdc fifo expose, since I don't want to commit to have that at the moment. Need more time to evaluate the API or alternatives. |
…_fifo_transdimension
HiFiPhile
force-pushed
the
xfer_fifo_transdimension
branch
from
1614eea
to
30df09b
Compare
This was referenced Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Various improvements in order to improve CDC efficiency.
Test result can be found in #920, which shows a great increment in throughput and
and reduce execution time.
tud_cdc_rx_wanted_cbis still WIP since can't be done without accessing underlying fifo struct membersAdditional context
Linear buffer is still used by default since more RAM maybe needed (at least 4K for dcd_transdimension), and no
tud_cdc_rx_wanted_cbfor the moment.Instead of export the fifo it's also possible to export only
tu_fifo_buffer_info_t, but it's inconsistent with audio class.