UAC2: Add xfer_fifo support for dcd_transdimension.#1063
Merged
Conversation
Add ring buffer ON/OFF switch.
HiFiPhile
changed the title
hathach
reviewed
Sep 26, 2021
Owner
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
Thank you for your PR, to be honest I don't entirely like the solution. Since I want to refactor the iso and its buffer usage. Though I could merge this as it is to make it easier for you (without keeping local changes in your fork), but keep in mind that TUD_AUDIO_PREFER_RING_BUFFER is subject to changed/refactored in the future.
Collaborator
Author
|
It depends on your planning. |
hathach
approved these changes
Sep 30, 2021
Owner
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
Since I don't know when I could work on this, will merge it as its for now, will probably refactor out later on. Thank you for your PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
#2nd part of #926
Maybe we can use a better name than
TUD_AUDIO_PREFER_RING_BUFFER.