-
Notifications
You must be signed in to change notification settings - Fork 0
upgrade to svelte 4, storybook 8 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Deploy Preview for hathitrust-firebird-common failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes on this PR sees fine. However, the deploy failed, then you should check the fails before merge it. We could probably check the fails during the maintenance co-working time
The netlify build is using an old version of node, but storybook version 8 needs node 18+ to build properly. We don't actually use netlify for anything anymore, and I don't have access to it. @respinos I know this is used as a fallback for js/css across the apps, but we don't really need it, right? |
@carylwyatt nope --- I can delete the netlify configuration. Y'all can then recreate it as needed. |
Thanks, @respinos! 🙌 |
upgrade to svelte 4
I followed the official migration guide and had no issues. Only a handful of components were affected and they were superficial changes (css transitions), so there would be no breaking changes, regardless. But I checked those components locally and on dev-3, and they seem to be fine!
upgrade to storybook 8
I used the migration helper tool to upgrade to version 8. There were a few breaking changes, and the migration tool checked the story files for those changes and helped me make necessary changes. There were a few issues, but they were easily remedied.
remove warnings
If you've ever built firebird during testing/staging/deploying, you may have noticed a long list of annoying warnings. Those warnings were not helpful and often made it difficult to see if an error was mixed in with the long wall of text. I went through various components and removed warnings by either specifically telling svelte to ignore a known problem or fixing the problem. I also updated the vite config (in both firebird and storybook) to exclude fonts/images that are usually found in the
/common/dist
folder but vite has a hard time finding them during build time because they're relative links (this doesn't affect how the components/apps work, it's just a compile warning). A few warnings still remain, but I hope to resolve those in the future.package audit fixes
There were three packages that needed updating according to
npm audit
. Those were upgraded without issue.Thanks to @liseli for working through this with me during Maintenance Monday! 🥇