Skip to content

Conversation

carylwyatt
Copy link
Member

@carylwyatt carylwyatt commented Apr 25, 2025

There are two changes here:

  1. the HTML page for cloudflare errors
  2. updates to the vite config for building the cloudflare page for production

I will squash commits before merging this one!

@carylwyatt carylwyatt requested a review from aelkiss April 25, 2025 17:11
Copy link
Member

@aelkiss aelkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. We aren't building any other HTML from this, but if we for some reason did in the future we might want to make sure that we don't remove the CSS link from that. Actually we are -- the index.html with meow_jamming.gif -- will we end up removing the stylesheet link from that & if so will that cause an issue?

@carylwyatt
Copy link
Member Author

eh, we've been building that index file since the beginning. we don't use it for anything, it's just there. i'm not worried about it, but we can remove it if you'd like. https://babel.hathitrust.org/common/firebird/dist/index.html

@carylwyatt
Copy link
Member Author

but to actually answer your question, the stylesheet was removed from the /dist/index.html page and caused no issues.

@aelkiss
Copy link
Member

aelkiss commented Apr 25, 2025

OK then I think we should be good to go 🚢

@carylwyatt carylwyatt merged commit d823d9d into main Apr 25, 2025
6 checks passed
@carylwyatt carylwyatt deleted the cloudflare-page branch April 25, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants