Skip to content

Conversation

carylwyatt
Copy link
Member

@carylwyatt carylwyatt commented Jul 22, 2025

The main changes here are in apps.scss, applying new colors to the selector a[data-activated-role]. The predecessor to these newer styles was in the stylesheet all along, but there was a typo (data-access-role) and the "Limited (access permitted)" labels in ls/mb/catalog never actually had the styles applied. 🫠

I added new stories to existing story files-- ResultsItem and ResultsList now have stories for the new "Registered Access" labels, and the ResultsItem labels that can have a "visited" icon now have a prop that can be toggled for viewing that state.

@carylwyatt carylwyatt changed the title ETT-216: update SERP label styles for resource sharing, add stories ETT-386: update SERP label styles for resource sharing, add stories Jul 23, 2025
@carylwyatt carylwyatt marked this pull request as ready for review July 23, 2025 14:01
@aelkiss aelkiss requested review from liseli and moseshll July 24, 2025 13:55
Copy link

@liseli liseli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine to me, I'll approve it but I recommend to squash all the commits before merging it.

Copy link

@moseshll moseshll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this. APPROVE.

@carylwyatt carylwyatt merged commit 10f7ade into main Aug 4, 2025
6 checks passed
@carylwyatt carylwyatt deleted the ETT-216 branch August 4, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants