ETT-498: fix notification manager #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove extra parameters from notification cookie setItem function - remove date logic from HT.prefs.set since that's in cookies setItem now - change setMonth to setDate in cookie setItem method
carylwyatt
force-pushed
the
ETT-498-notification-manager
branch
from
69fd0d8 to
441bad6
Compare
liseli
approved these changes
Aug 7, 2025
|
@giramesh tested the UI flow on this fix and has given approval. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ange reported something I had noticed: notifications that had been dismissed were opening on every page load. I didn't think much of it, but it is pretty annoying!
After some investigation, I found that when @aelkiss and I refactored the cookie logic in ETT-309, I missed updating the
setItemfunction in thenotifications.js. I tested this on dev-3, and removing those parameters from the function fixed the issue.I found one other
setItemfunction that hadn't been updated inutils.jsthat sets a cookie for various preferences, so I fixed that, too.When I was testing, I noticed that expiration dates on the cookies didn't make sense. Turns out we used
setMonthinstead ofsetDatemethod on the Date instance. When I ran that logic in the console, it was setting the expiration date for 90 months from now, in 2033. 🫠 That's fixed now.