Bugfix: send instance label as part of group #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For instance to be used as part of the group, it needs to be included with the URL we post to. While other labels can be used as part of the group, it appears customary to use instance. If we need additional groups, we could add support for arbitrary group labels here. * Stricter tests around where we expect instance to appear * New test ensuring instances don't clobber each other
moseshll
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance to be used as part of the group, it needs to be included with the URL we post to. While other labels can be used as part of the group (https://github.com/prometheus/pushgateway?tab=readme-ov-file#url), it appears customary to use instance (see https://github.com/prometheus/pushgateway?tab=readme-ov-file#command-line). If we need additional groups, we could add support for arbitrary group labels here in the future.