[WIP] Revisions list on course modal #2289
Conversation
|
I'd like to iterate on this to make things cleaner and more componentized. Feedback would be much appreciated. |
|
Also, flow is about to yell. |
| return ( | ||
| <ul key={index}> | ||
| <RevisionTitle>{revisionDate}</RevisionTitle> | ||
| {Object.keys(items).map( |
There was a problem hiding this comment.
Use lodash.toPairs here, instead of iterating over the keys, so that you have easy access to both the keys and values.
There was a problem hiding this comment.
lodash.toPairs throws Object(...) is not a function
There was a problem hiding this comment.
You will need to look at the documentation
|
Lodash's toEntries plays nicer with flow. Please use it. |
drewvolz
changed the title
drewvolz
force-pushed
the
revision-history
branch
from
db883e9
to
e7e2dfd
Compare
| @@ -30,17 +31,17 @@ export class Revisions extends React.Component<Props> { | |||
| ) | |||
|
|
|||
| return ( | |||
| <ul key={index}> | |||
| <BulletedList key={index}> | |||
| <RevisionTitle>{revisionDate}</RevisionTitle> | |||
There was a problem hiding this comment.
This needs to be in a ListItem as well, if you go this route. You should have
- Date
- enrolled: 31
- max: 32
There was a problem hiding this comment.
Right. I was updating the branch to match master, so I haven't attempted this yet. It looks like we'll need to build in indented list-item support to the list module.
|
I'd like something like this, maybe ## October 2, 2017
Key | Before | After
-------- | ------ | -----
enrolled | 31 | 32
max | 15 | 35
## October 1, 2017
Key | Before | After
-------- | ------ | -----
enrolled | 30 | 31
max | 30 | 15I'd like to be able to see what changed on each day, without having to mentally cross-reference the days. I'm not tied to the table, but something like that to present all the information compactly. |
drewvolz
force-pushed
the
revision-history
branch
from
e7e2dfd
to
e5b9260
Compare
# Conflicts: # modules/gob-web/modules/course/expanded.js
Part of #946
This lists the revisions in a collapsed details/summary element.
Known Issues: