Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Contexts,Exchanges,Attributes to TableComposable #869

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

mmelko
Copy link
Collaborator

@mmelko mmelko commented Apr 10, 2024

I migrated tables to use TableComposable instead of old PF4 table.
Also fixed #845 by refactoring selected const to use list of strings instead Context objects.
close #180

Copy link

github-actions bot commented Apr 10, 2024

Test Results

  8 files  ±0    8 suites  ±0   47m 0s ⏱️ +15s
 60 tests ±0   58 ✅ ±0   2 💤 ±0  0 ❌ ±0 
488 runs  ±0  460 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit 9134609. ± Comparison against base commit cecba47.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Apr 10, 2024

Test results

Run attempt: 1460
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 61 58 3 0 0 358
results-quarkus-node(18)-java(21)-firefox 61 58 3 0 0 347.759
results-quarkus-node(20)-java(17)-firefox 61 58 3 0 0 349.102
results-quarkus-node(20)-java(21)-firefox 61 58 3 0 0 346.293
results-springboot-node(18)-java(17)-firefox 61 57 4 0 0 348.161
results-springboot-node(18)-java(21)-firefox 61 57 4 0 0 348.582
results-springboot-node(20)-java(17)-firefox 61 57 4 0 0 359.488
results-springboot-node(20)-java(21)-firefox 61 57 4 0 0 363.306

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for now, but ideally #845 should be fixed by splitting the component into smaller chunks so that the effect of re-rendering is narrowed to a specific component.

@mmelko
Copy link
Collaborator Author

mmelko commented Apr 11, 2024

@tadayosi I don't think that was a problem actually. Contexts component is fairly simple. My impression was that problem was that for selectedState was used actually array of the ContextState objects. I assume it could be a problem of references in the array. Refactoring the selected state to actually to the array of the strings did the trick

@tadayosi tadayosi merged commit 26df634 into hawtio:main Apr 11, 2024
13 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camel context selection dissapears after a while Upgrade instance of Patternfly Table to TableComposable
3 participants