Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Source): Use dynamic height instead of fixed height in pixels #920

Merged
merged 1 commit into from
May 7, 2024

Conversation

mmelko
Copy link
Collaborator

@mmelko mmelko commented May 3, 2024

No description provided.

Copy link

github-actions bot commented May 3, 2024

Test Results

  8 files  ±0    8 suites  ±0   47m 49s ⏱️ -31s
 66 tests ±0   64 ✅ ±0   2 💤 ±0  0 ❌ ±0 
536 runs  ±0  508 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit d12d5cf. ± Comparison against base commit 7e05b79.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented May 3, 2024

Test results

Run attempt: 1618
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 353.87
results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 354.994
results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 360.484
results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 357.965
results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 359.355
results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 359.622
results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 362.03
results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 361.006

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time, please provide before/after screenshots so that reviewers can better assess whether it's the right way to fix the issue.

@tadayosi tadayosi merged commit f6a72f1 into hawtio:main May 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants