Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2.x]refactor(preferences-plugin): adjust the look to be consistent with the rest of the plugins #935

Merged
merged 1 commit into from
May 9, 2024

Conversation

mmelko
Copy link
Collaborator

@mmelko mmelko commented May 9, 2024

Screenshot 2024-05-09 at 13 49 39

(cherry picked from commit c9a09dd)

…he rest of the plugins

(cherry picked from commit c9a09dd)
Copy link

github-actions bot commented May 9, 2024

Test Results

  8 files  ± 0    8 suites  ±0   50m 22s ⏱️ + 6m 9s
 66 tests ± 0   64 ✅ + 1   2 💤 ±0  0 ❌  - 1 
535 runs  +65  507 ✅ +62  28 💤 +4  0 ❌  - 1 

Results for commit 0b7748d. ± Comparison against base commit cf99b6b.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented May 9, 2024

Test results

Run attempt: 1679
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 375.952
results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 371.971
results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 377.771
results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 378.881
results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 370.531
results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 379.47
results-springboot-node(20)-java(17)-firefox 66 62 4 0 0 384.586
results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 383.478

Copy link
Member

@phantomjinx phantomjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmelko mmelko merged commit 7b08723 into hawtio:1.2.x May 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants