Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connect): Disable "Connect" button in Discovery when in insecure … #947

Merged
merged 1 commit into from
May 16, 2024
Merged

fix(connect): Disable "Connect" button in Discovery when in insecure … #947

merged 1 commit into from
May 16, 2024

Conversation

grgrzybek
Copy link
Contributor

…context

@grgrzybek grgrzybek requested a review from tadayosi May 16, 2024 09:09
@github-actions GitHub Actions
Copy link

github-actions bot commented May 16, 2024 •
edited
Loading

Test Results

  8 files  ±0    8 suites  ±0   49m 50s ⏱️ -11s
 65 tests ±0   63 ✅ ±0   2 💤 ±0  0 ❌ ±0 
528 runs  ±0  500 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit ee3cf18. ± Comparison against base commit 8c42118.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented May 16, 2024 •
edited
Loading

Test results

Run attempt: 1746
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 66 63 3 0 0 374.795
results-quarkus-node(18)-java(21)-firefox 66 63 3 0 0 367.876
results-quarkus-node(20)-java(17)-firefox 66 63 3 0 0 374.77
results-quarkus-node(20)-java(21)-firefox 66 63 3 0 0 375.337
results-springboot-node(18)-java(17)-firefox 66 62 4 0 0 375.37
results-springboot-node(18)-java(21)-firefox 66 62 4 0 0 370.861
results-springboot-node(20)-java(17)-firefox 66 62 4 0 0 375.635
results-springboot-node(20)-java(21)-firefox 66 62 4 0 0 375.379

phantomjinx
phantomjinx approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@phantomjinx phantomjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgrzybek grgrzybek merged commit 45e32ec into main May 16, 2024
13 checks passed
@grgrzybek grgrzybek deleted the connect-discovery-fixes branch May 16, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phantomjinx phantomjinx phantomjinx approved these changes

@tadayosi tadayosi Awaiting requested review from tadayosi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grgrzybek @phantomjinx