Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicated security context fields in mancenter-statefulset.yaml #286

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

semihbkgr
Copy link
Contributor

I removed the duplicated securityContext fields in mancenter-statefulset.yaml files.

{{- if .Values.securityContext.enabled }}
  securityContext:
    fsGroup: {{ .Values.securityContext.fsGroup }}
{{- end }}

These duplicated fields cause to error when building templates by kustomize.

mapping key "securityContext" already defined

see also #278

@devOpsHazelcast
Copy link

devOpsHazelcast commented Jul 20, 2022

CLA assistant check
All committers have signed the CLA.

@mtyazici
Copy link
Contributor

@semihbkgr Could you also test the case where SecurityContext is removed from the values.yaml. I think it should give an error and to solve it we should use the if condition to check if the SecurityContext is enabled.

Copy link
Contributor

@mtyazici mtyazici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

@semihbkgr semihbkgr merged commit 8441697 into hazelcast:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants