fix lint errors #30
fix lint errors #30
Conversation
| @@ -83,11 +86,9 @@ spec: | |||
| {{- end }} | |||
| - name: JAVA_OPTS | |||
| value: "-Dhazelcast.rest.enabled={{ .Values.hazelcast.rest }} -Dhazelcast.config=/data/hazelcast/hazelcast.xml -DserviceName={{ template "hazelcast.fullname" . }} -Dnamespace={{ .Release.Namespace }} -Dhazelcast.mancenter.enabled={{ .Values.mancenter.enabled }} -Dhazelcast.mancenter.url=http://{{ template "mancenter.fullname" . }}:{{ .Values.mancenter.service.port }}/hazelcast-mancenter {{ if .Values.gracefulShutdown.enabled }}-Dhazelcast.shutdownhook.policy=GRACEFUL -Dhazelcast.shutdownhook.enabled=true -Dhazelcast.graceful.shutdown.max.wait={{ .Values.gracefulShutdown.maxWaitSeconds }} {{ end }} {{ if .Values.metrics.enabled }}-Dhazelcast.jmx=true{{ end }} {{ .Values.hazelcast.javaOpts }}" | |||
| serviceAccountName: {{ template "hazelcast.serviceAccountName" . }} | |||
There was a problem hiding this comment.
What service account it used if it's not specified here?
There was a problem hiding this comment.
serviceAccountName is already being set at the Pod object level correctly here
serviceAccountName is not valid at the Container object level
| @@ -81,7 +83,6 @@ spec: | |||
| {{- if .Values.securityContext.enabled }} | |||
| securityContext: | |||
| runAsUser: {{ .Values.securityContext.runAsUser }} | |||
| fsGroup: {{ .Values.securityContext.fsGroup }} | |||
There was a problem hiding this comment.
How do you set the fsGroup then? Don't we have any case when it's useful to set it?
There was a problem hiding this comment.
fsGroup is already being set at the Pod securityContext object level correctly here
fsGroup is not valid at the Container securityContext object level
|
|
@dacleyra |
|
Any updates on this, be good to get this in before we push to the main helm repo. |
|
I have not gotten approval to sign the CLA yet, sorry. |
|
I was denied permission to sign the CLA. |
[ERROR] templates/mancenter-deployment.yaml: invalid schema: ValidationError(Deployment.spec.template.spec.containers[0].securityContext): unknown field "fsGroup" in io.k8s.api.core.v1.SecurityContextfsGroup is not a option for the securityContext of the Container, only the Pod
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#securitycontext-v1-core
[ERROR] templates/mancenter-deployment.yaml: missing required metadata labels: missing chart, heritage under spec.template.metadata.labelsAdded the labels
[ERROR] templates/statefulset.yaml: invalid schema: [ValidationError(StatefulSet.spec.template.spec.containers[0].securityContext): unknown field "fsGroup" in io.k8s.api.core.v1.SecurityContext,fsGroup is not a option for the securityContext of the Container, only the Pod
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#securitycontext-v1-core
ValidationError(StatefulSet.spec.template.spec.containers[0]): unknown field "serviceAccountName" in io.k8s.api.core.v1.Container,serviceAccountName is not an option on Container, only Pod
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#container-v1-core
ValidationError(StatefulSet.spec): missing required field "serviceName" in io.k8s.api.apps.v1.StatefulSetSpec]Connect the StatefulSet to the Service identity
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#statefulsetspec-v1-apps
https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#stable-network-id