PNCounter #218
PNCounter #218
Conversation
|
Linux Net Core Tests PASSed. |
Hazelcast.Test/Hazelcast.Client.Test/ClientPNCounterConsistencyLossTest.cs
Outdated
Show resolved
Hide resolved
Hazelcast.Test/Hazelcast.Client.Test/ClientPNCounterConsistencyLossTest.cs
Show resolved
Hide resolved
|
Windows Net Core Tests PASSed. |
| namespace Hazelcast.Client.Test | ||
| { | ||
| [TestFixture] | ||
| public class ClientPNCounterTest : MultiMemberBaseTest |
There was a problem hiding this comment.
Need a clean up here :
[TestFixture]
public class ClientPNCounterTest : SingleMemberBaseTest
{
private ClientPNCounterProxy _pnCounter;
[SetUp]
public void Setup()
{
_pnCounter = Client.GetPNCounter(TestSupport.RandomString()) as ClientPNCounterProxy;
}
[TearDown]
public void TearDown()
{
}
[Test]
public void Reset_Succeeded()
{
_pnCounter.Reset();
}
...
We still need this
|
Windows .Net Framework Tests PASSed. |
|
Linux Net Core Tests PASSed. |
|
Windows .Net Framework Tests PASSed. |
|
Windows Net Core Tests PASSed. |
|
|
||
| namespace Hazelcast.Client.Test | ||
| { | ||
| public class VectorClockTest : SingleMemberBaseTest |
| } | ||
|
|
||
| [TearDown] | ||
| public static void Destroy() |
There was a problem hiding this comment.
older Nunit(pre 2.5) mandate static tear-down method but it's not required anymore. Non-static one would be better in new implementations
| public class VectorClockTest : SingleMemberBaseTest | ||
| { | ||
| internal static VectorClock _inst; | ||
| internal const string name = "ClientPNCounterTest"; |
| { | ||
| public class VectorClockTest : SingleMemberBaseTest | ||
| { | ||
| internal static VectorClock _inst; |
There was a problem hiding this comment.
can be private non-static with Teardown method change
Hazelcast.Test/Hazelcast.Test.csproj
Outdated
| <ItemGroup> | ||
| <EmbeddedResource Include="Resources\*" /> | ||
| </ItemGroup> | ||
| <ItemGroup> |
There was a problem hiding this comment.
We don't need these as above <EmbeddedResource Include="Resources\*" /> adds everthing
|
Linux Net Core Tests PASSed. |
|
Windows .Net Framework Tests PASSed. |
|
Linux Net Core Tests PASSed. |
|
Windows Net Core Tests PASSed. |
|
Linux Net Core Tests PASSed. |
|
Windows .Net Framework Tests PASSed. |
|
Windows .Net Framework Tests PASSed. |
|
Windows Net Core Tests PASSed. |
|
Linux Net Core Tests PASSed. |
|
Windows .Net Framework Tests PASSed. |
|
Windows Net Core Tests PASSed. |
|
Linux Net Core Tests PASSed. |
|
Windows .Net Framework Tests PASSed. |
|
Windows Net Core Tests PASSed. |
|
Linux Net Core Tests PASSed. |
|
Windows .Net Framework Tests FAILed. |
|
Windows Net Core Tests PASSed. |
|
Test failed on timeout. The test run from Visual Studio passed conditions without any problems |
|
verify |
|
Linux Net Core Tests PASSed. |
|
Windows Net Core Tests PASSed. |
|
Windows .Net Framework Tests PASSed. |
|
Linux Net Core Tests PASSed. |
|
Windows Net Core Tests PASSed. |
|
Windows .Net Framework Tests PASSed. |
PNCounter