SSL setup should respect setting of the protocols #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client-side certPath specified
|
Linux Net Core Tests PASSed. |
|
Windows .Net Framework Tests PASSed. |
|
Windows Net Core Tests PASSed. |
asimarslan
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way
SSLProtocolsare resoled when no client-side certPath specified. Before this change, whenever thecertPathwas not specified the following methods was used:which underneath delegates the selection to
ServicePointManager.DefaultSslProtocols. This means that the user setting for the SSL/TLS protocol was ignored. With this change it always uses the value specified by the client.Risks
Potentially this is a breaking change, as whenever the setting in Hazelcast settings was different from the ServicePointManager, it would impact the selection.