Session State Provider [API-83]

[emreyigit]

Async extensions and documentation added for ISession interface.

[zpqrtbnk]

So just to be sure - the simple fact that we register our own IDistributedCache implementation for the web app cache, means that sessions will rely on it, and load/store themselves from it, all magically? That's great. Have you tested that it works with a sample web app?

And then, the few extension methods that you provide are for providing asynchronous access to the session, right? Because the default mode is synchronous and can cause threading issues, right?

[zpqrtbnk]

Commented

[codecov-commenter]

Codecov Report

Merging #786 (535f7e6) into master (961e379) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
- Coverage   84.77%   84.69%   -0.08%     
==========================================
  Files         885      885              
  Lines       20908    20919      +11     
==========================================
- Hits        17724    17717       -7     
- Misses       3184     3202      +18     

Impacted Files	Coverage Δ
src/Hazelcast.Net/HazelcastOptionsBuilder.cs	25.00% <0.00%> (-75.00%)	⬇️
src/Hazelcast.Net/HazelcastOptionsBuilderBase.cs	83.72% <0.00%> (-8.59%)	⬇️
src/Hazelcast.Net/Clustering/ClusterConnections.cs	79.62% <0.00%> (-1.24%)	⬇️
...c/Hazelcast.Net/Networking/SocketConnectionBase.cs	99.23% <0.00%> (-0.77%)	⬇️
src/Hazelcast.Net/Clustering/ClusterMembers.cs	77.90% <0.00%> (-0.75%)	⬇️
src/Hazelcast.Net/Core/Symbols.cs	16.66% <0.00%> (ø)
src/Hazelcast.Net.Linq.Async/MapEntry.cs	62.50% <0.00%> (ø)
src/Hazelcast.Net.Linq.Async/HMemberInfo.cs	87.50% <0.00%> (ø)
src/Hazelcast.Net/Serialization/HeapData.cs	61.22% <0.00%> (ø)
src/Hazelcast.Net/Clustering/ClusterMessaging.cs	97.53% <0.00%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[emreyigit]

So just to be sure - the simple fact that we register our own IDistributedCache implementation for the web app cache, means that sessions will rely on it, and load/store themselves from it, all magically? That's great. Have you tested that it works with a sample web app?
And then, the few extension methods that you provide are for providing asynchronous access to the session, right? Because the default mode is synchronous and can cause threading issues, right?

Yes. It's exactly as you described. We only provide async extensions to be compatible nature of Hazelcast client. Also, I've tested with in an ASP.NET Core project, and it works :) . Only thing you need to do use session app.UseSession(); after adding Hazelcast cache into services.

[zpqrtbnk]

approved