-
Notifications
You must be signed in to change notification settings - Fork 52
Sql Partition Aware Client [API-1861] #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # src/Hazelcast.Net/Sql/SqlService.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have reviewed it all except the ReadOptimizedLruCache
but already posting comments.
src/Hazelcast.Net/Protocol/Codecs/ClientAuthenticationCustomCodec.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more comments
Co-authored-by: Stephan <sgay@pilotine.com>
Co-authored-by: Stephan <sgay@pilotine.com>
Co-authored-by: Stephan <sgay@pilotine.com>
Co-authored-by: Stephan <sgay@pilotine.com>
Co-authored-by: Stephan <sgay@pilotine.com>
Co-authored-by: Stephan <sgay@pilotine.com>
Co-authored-by: Stephan <sgay@pilotine.com>
Co-authored-by: Stephan <sgay@pilotine.com>
# Conflicts: # src/Hazelcast.Net/HazelcastOptions.cs # src/Hazelcast.Net/PublicAPI/PublicAPI.Unshipped.txt
Codecov Report
@@ Coverage Diff @@
## master #798 +/- ##
==========================================
+ Coverage 84.69% 84.73% +0.04%
==========================================
Files 885 885
Lines 20921 20952 +31
==========================================
+ Hits 17719 17754 +35
+ Misses 3202 3198 -4
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Sql partition aware feature implemented. Since feature requires protocol updates, protocol submodule and the files are regenerated and aligned.