Skip to content

Conversation

emreyigit
Copy link
Collaborator

@emreyigit emreyigit commented Feb 28, 2023

Sql partition aware feature implemented. Since feature requires protocol updates, protocol submodule and the files are regenerated and aligned.

@emreyigit emreyigit added this to the 5.3.0 milestone Feb 28, 2023
@emreyigit emreyigit marked this pull request as ready for review March 17, 2023 15:29
@emreyigit emreyigit requested a review from zpqrtbnk March 22, 2023 09:08
Copy link
Contributor

@zpqrtbnk zpqrtbnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have reviewed it all except the ReadOptimizedLruCache but already posting comments.

Copy link
Contributor

@zpqrtbnk zpqrtbnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more comments

emreyigit and others added 13 commits March 25, 2023 15:53
Co-authored-by: Stephan <sgay@pilotine.com>
Co-authored-by: Stephan <sgay@pilotine.com>
Co-authored-by: Stephan <sgay@pilotine.com>
Co-authored-by: Stephan <sgay@pilotine.com>
Co-authored-by: Stephan <sgay@pilotine.com>
Co-authored-by: Stephan <sgay@pilotine.com>
Co-authored-by: Stephan <sgay@pilotine.com>
Co-authored-by: Stephan <sgay@pilotine.com>
# Conflicts:
#	src/Hazelcast.Net/HazelcastOptions.cs
#	src/Hazelcast.Net/PublicAPI/PublicAPI.Unshipped.txt
@codecov-commenter
Copy link

Codecov Report

Merging #798 (9a8ab57) into master (ff3899a) will increase coverage by 0.04%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
+ Coverage   84.69%   84.73%   +0.04%     
==========================================
  Files         885      885              
  Lines       20921    20952      +31     
==========================================
+ Hits        17719    17754      +35     
+ Misses       3202     3198       -4     
Impacted Files Coverage Δ
...st.Net/Protocol/Codecs/AtomicLongAddAndGetCodec.cs 100.00% <ø> (ø)
...et/Protocol/Codecs/AtomicLongCompareAndSetCodec.cs 100.00% <ø> (ø)
...st.Net/Protocol/Codecs/AtomicLongGetAndAddCodec.cs 100.00% <ø> (ø)
...st.Net/Protocol/Codecs/AtomicLongGetAndSetCodec.cs 100.00% <ø> (ø)
...azelcast.Net/Protocol/Codecs/AtomicLongGetCodec.cs 100.00% <ø> (ø)
...Net/Protocol/Codecs/AtomicRefCompareAndSetCodec.cs 100.00% <ø> (ø)
...cast.Net/Protocol/Codecs/AtomicRefContainsCodec.cs 100.00% <ø> (ø)
...Hazelcast.Net/Protocol/Codecs/AtomicRefGetCodec.cs 100.00% <ø> (ø)
...Hazelcast.Net/Protocol/Codecs/AtomicRefSetCodec.cs 100.00% <ø> (ø)
...t.Net/Protocol/Codecs/CPGroupCreateCPGroupCodec.cs 100.00% <ø> (ø)
... and 278 more

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@zpqrtbnk zpqrtbnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@emreyigit emreyigit merged commit b81ff35 into hazelcast:master Apr 6, 2023
@emreyigit emreyigit deleted the sql-partition-aware branch July 4, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants