Implement TPC #830
Merged
Implement TPC #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for silly-valkyrie-e996d9 pending review.Visit the deploys page to approve it
|
emreyigit
reviewed
May 11, 2023
|
|
||
| try | ||
| { | ||
| // TODO: should the parallel count be an option? what is a good value? |
There was a problem hiding this comment.
How about count of tcp ports? Is it too dynamic?
emreyigit
approved these changes
May 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #830 +/- ##
==========================================
+ Coverage 84.29% 84.50% +0.21%
==========================================
Files 892 890 -2
Lines 21124 21114 -10
==========================================
+ Hits 17807 17843 +36
+ Misses 3317 3271 -46
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the big PR. It implemented TPC as per the TDD.
TpcOptionsand plumbingCloudDiscoveryto also discover TPC portsMemberConnectionnow handles TPCComes with sets of tests.