-
Notifications
You must be signed in to change notification settings - Fork 52
Implement dynamic configuration / map+ringbuffer [API-2175] #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Deploy Preview for silly-valkyrie-e996d9 failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the PR generally. I've left a few comments. Also, as I can see there are options but cannot be set or used yet. We should decrease their access modifiers since they are not avaiable tough declared as public. Also, excluding them from tests could be good idea until related implementation completed. They decrease the overall coverage.
This PR implements the core dynamic configuration support with all codecs etc + the map and ringbuffer configuration user code. Anything else is not part of this PR as it will quite probably be exposed via a REST API and not via dynamic configuration fluent API. Users can do, for instance:
Note
We have tests to ensure that (1) the server would accept a complete configuration and (2) Java and .NET would produce the very same client message for the default dynamic configuration.
There are also a number of changes to files due to our public API surface going a bit out-of-control in the past PRs. In theory we have files that define our public API and detect any unwanted changes, but this detection seems to have been ignored in past PRs so it's all out of sync. Bringing it back in sync here.
NOTE: before merging this PR, ensure that hazelcast/hazelcast-client-protocol#496 is merged and update the state of the protocol sub-repository accordingly.
NOTE: as part of the merge, ensure that all
v5.3.1
tag and5.3.z
branch have been properly merged intomaster
.