Skip to content

Conversation

emreyigit
Copy link
Collaborator

@emreyigit emreyigit commented Dec 26, 2023

This PR add CPMap support to .Net Client. The implementation is pure client protocol invocations.

Please, see the example and documentation for usage.

@emreyigit emreyigit added this to the 5.4.0 milestone Dec 26, 2023
@emreyigit emreyigit self-assigned this Dec 26, 2023
Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for silly-valkyrie-e996d9 failed.

Name Link
🔨 Latest commit aa4e385
🔍 Latest deploy log https://app.netlify.com/sites/silly-valkyrie-e996d9/deploys/65a7b508f205c20007e0368d

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (048f52c) 84.88% compared to head (aa4e385) 84.70%.
Report is 1 commits behind head on master.

Files Patch % Lines
...t.Net/Protocol/Codecs/ClientAuthenticationCodec.cs 0.00% 12 Missing ⚠️
...Protocol/Codecs/ClientAuthenticationCustomCodec.cs 0.00% 12 Missing ⚠️
...rc/Hazelcast.Net/Protocol/Codecs/MapDeleteCodec.cs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #866      +/-   ##
==========================================
- Coverage   84.88%   84.70%   -0.18%     
==========================================
  Files         914      914              
  Lines       21638    21679      +41     
==========================================
- Hits        18367    18363       -4     
- Misses       3271     3316      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emreyigit emreyigit marked this pull request as ready for review December 29, 2023 13:09
@emreyigit emreyigit requested a review from zpqrtbnk January 8, 2024 09:20
Copy link
Contributor

@zpqrtbnk zpqrtbnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented.

@zpqrtbnk
Copy link
Contributor

additional note: need to verify that this is listed in the CP SubSystem documentation page.

zpqrtbnk
zpqrtbnk previously approved these changes Jan 16, 2024
@emreyigit emreyigit merged commit 7ee3df8 into hazelcast:master Jan 17, 2024
@emreyigit emreyigit deleted the cp-map branch July 4, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants