Implement CP CountDownLatch [API-253] #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpqrtbnk
added
Type: Feature
❌ Deploy Preview for silly-valkyrie-e996d9 failed.
|
zpqrtbnk
changed the title
emreyigit
reviewed
Jan 16, 2024
| return CountDownLatchTrySetCountCodec.DecodeResponse(responseMessage).Response; | ||
| } | ||
|
|
||
| public override async ValueTask DestroyAsync() |
There was a problem hiding this comment.
Let's keep the the coverage up. Could you also add a test for destroying?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #870 +/- ##
==========================================
+ Coverage 84.78% 84.81% +0.03%
==========================================
Files 923 923
Lines 21848 21852 +4
==========================================
+ Hits 18523 18534 +11
+ Misses 3325 3318 -7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements CountDownLatch.