Fix test_lifecycle_listener_receives_disconnected_event
#417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test failed in Github Actions runners. The reason of the failure is that, we try to check the received events right after shutting down the member. It might be the case that, the member is shutdown, but it is not visible to the client yet. To tackle that, we now use `assertTrueEventually` to verify that we receive the event.
srknzl
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test failed in Github Actions runners. The reason of the failure
is that, we try to check the received events right after shutting down
the member. It might be the case that, the member is shutdown, but
it is not visible to the client yet.
To tackle that, we now use
assertTrueEventuallyto verify thatwe receive the event.