-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of failed updates #284
Comments
Also experienced in #313. |
Seems I lost track of this issue, and it might be a simple fix.
Pushed 5d41b7b to only write the last successful update date after actual success.
I think this one is actually nice the way it is, since we have a full record of what happened. When we look at the backups, we see the update happened, but the file was empty. If it's not there, we don't know if something was there and was later deleted etc. What do you think, @dr0i?
I think with the fix above, this is already handled: on the next day, we'll use the same older start day again, as on the day before, since we did not update the date when we got no data.
I think with the fix above, this should be fine too: if the response is not completely empty, the date will be updated, and on the next day we'll continue, as if there had been some updates. |
+1 for keeping copy of empty update files. |
We need to improve handling of failing updates.
On 2021-02-03 we got a "GND updates fails" email. After a quick check in the the
data/backup
folder all updates seemed to be there. We have a mechanism that should include missed updates on the next day (GND-lastSuccessfulUpdate.txt, see https://github.com/hbz/lobid-gnd/blob/master/cron.sh). But thankfully @dr0i pushed me to investigate if this actually worked, and it didn't: the backup file is empty, so we either missed updates for that day or there were no updates(?).What we should do:
- [ ] Don't copy empty update files todata/backup
The text was updated successfully, but these errors were encountered: