-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some GND labels not correctly built from Aleph XML #179
Comments
@jschnasse Let us know if this has to be prioritized. |
Similar to lobid/lodmill#735 but for corporations. |
Another example: Source: <datafield ind2="1" ind1="-" tag="200">
<subfield code="k">Deutschland</subfield>
<subfield code="b">Bundesministerium für Gesundheit</subfield>
<subfield code="9">(DE-588)2117859-8</subfield>
</datafield>
<datafield ind2="1" ind1="a" tag="204">
<subfield code="k">Deutschland</subfield>
<subfield code="b">Umweltbundesamt</subfield>
<subfield code="9">(DE-588)2116834-9</subfield>
</datafield> Current JSON: {
"@id" : "http://d-nb.info/gnd/2117859-8",
"preferredName" : "Deutschland",
"preferredNameForThePerson" : "Deutschland"
}, {
"@id" : "http://d-nb.info/gnd/2116834-9",
"preferredName" : "Deutschland",
"preferredNameForThePerson" : "Deutschland"
} Expected JSON: {
"@id" : "http://d-nb.info/gnd/2117859-8",
"preferredName" : "Deutschland. Bundesministerium für Gesundheit",
"preferredNameForThePerson" : "Deutschland. Bundesministerium für Gesundheit"
}, {
"@id" : "http://d-nb.info/gnd/2116834-9",
"preferredName" : "Deutschland. Umweltbundesamt",
"preferredNameForThePerson" : "Deutschland. Umweltbundesamt"
} |
Prerequisite for hbz/lobid#179. - adjust test
See hbz/lobid#179. - adjust tests - renaming variables resulting in these 4 logical combinations: [creator|contributor][person|coporateBody] - reorder rules treating corporate bodies and persons - change some comments for more enlightment
Data will be deployed tomorrow for testing. |
Looks great from my side: +1 @jschnasse What do you think? |
http://test.lobid.org/resource?author=36467-8 looks still wrong? |
The test instance is automatically switched to the newest index which is build weekly at the weekend, not having the commit merged thus not having the new data in it. |
+1 |
Deployed to production, closing. |
E.g. , the label of GND entity http://d-nb.info/gnd/36467-8 isn't correctly transformed to RDF, see http://lobid.org/resource?author=36467-8. lt should read "Rheinland-Pfalz. Statistisches Landesamt" or similar and not only "Rheinland Pfalz".
Example source data (snippet):
In RDF, subfields
h
andk
should be concatenated, resulting in:The text was updated successfully, but these errors were encountered: