Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some GND labels not correctly built from Aleph XML #179

Closed
acka47 opened this issue Jun 24, 2015 · 9 comments
Closed

Some GND labels not correctly built from Aleph XML #179

acka47 opened this issue Jun 24, 2015 · 9 comments
Assignees

Comments

@acka47
Copy link
Contributor

acka47 commented Jun 24, 2015

E.g. , the label of GND entity http://d-nb.info/gnd/36467-8 isn't correctly transformed to RDF, see http://lobid.org/resource?author=36467-8. lt should read "Rheinland-Pfalz. Statistisches Landesamt" or similar and not only "Rheinland Pfalz".

Example source data (snippet):

<datafield tag="205" ind1="-" ind2="1">
   <subfield code="k">Statistisches Landesamt</subfield>
   <subfield code="h">Rheinland-Pfalz</subfield>
</datafield>

In RDF, subfields h and kshould be concatenated, resulting in:

{
    "@id" : "http://d-nb.info/gnd/36467-8",
    "preferredName" : "Rheinland Pfalz. Statistisches Landesamt",
    "preferredNameForTheCorporateBody" : "Rheinland Pfalz. Statistisches Landesamt"
}
@acka47 acka47 self-assigned this Jun 24, 2015
@acka47
Copy link
Contributor Author

acka47 commented Jun 24, 2015

@jschnasse Let us know if this has to be prioritized.

@acka47 acka47 changed the title Some GND labels not correlty built from Aleph XML Some GND labels not correctly built from Aleph XML Jun 24, 2015
@acka47 acka47 added the working label Oct 19, 2015
@acka47 acka47 assigned dr0i and unassigned acka47 Oct 19, 2015
@acka47
Copy link
Contributor Author

acka47 commented Oct 19, 2015

Similar to lobid/lodmill#735 but for corporations.

@acka47
Copy link
Contributor Author

acka47 commented Oct 19, 2015

Another example:

Source:

<datafield ind2="1" ind1="-" tag="200">
            <subfield code="k">Deutschland</subfield>
            <subfield code="b">Bundesministerium für Gesundheit</subfield>
            <subfield code="9">(DE-588)2117859-8</subfield>
</datafield>
<datafield ind2="1" ind1="a" tag="204">
            <subfield code="k">Deutschland</subfield>
            <subfield code="b">Umweltbundesamt</subfield>
            <subfield code="9">(DE-588)2116834-9</subfield>
</datafield>

Current JSON:

{
    "@id" : "http://d-nb.info/gnd/2117859-8",
    "preferredName" : "Deutschland",
    "preferredNameForThePerson" : "Deutschland"
 }, {
    "@id" : "http://d-nb.info/gnd/2116834-9",
    "preferredName" : "Deutschland",
    "preferredNameForThePerson" : "Deutschland"
  }

Expected JSON:

{
    "@id" : "http://d-nb.info/gnd/2117859-8",
    "preferredName" : "Deutschland. Bundesministerium für Gesundheit",
    "preferredNameForThePerson" : "Deutschland. Bundesministerium für Gesundheit"
 }, {
    "@id" : "http://d-nb.info/gnd/2116834-9",
    "preferredName" : "Deutschland. Umweltbundesamt",
    "preferredNameForThePerson" : "Deutschland. Umweltbundesamt"
  }

dr0i added a commit to lobid/lodmill that referenced this issue Oct 20, 2015
Prerequisite for hbz/lobid#179.

- adjust test
dr0i added a commit to lobid/lodmill that referenced this issue Oct 22, 2015
See hbz/lobid#179.

- adjust tests
- renaming variables resulting in these 4 logical combinations:
		[creator|contributor][person|coporateBody]
- reorder rules treating corporate bodies and persons
- change some comments for more enlightment
@dr0i dr0i added review and removed working labels Oct 22, 2015
@dr0i
Copy link
Member

dr0i commented Oct 22, 2015

Data will be deployed tomorrow for testing.
Because I don't work tomorrow:
If you find staging good, go on and merge the open pull request. Data will then be ready on monday and I can go to deploy them to production then.
(if you feel bold or @fsteeg can help you, you may also want to switch staging index to production tomorrow. Hm. Ok this only takes 2 minutes, I will probably have a look tomorrow myself and will switch myself :) )

@dr0i dr0i assigned acka47 and unassigned dr0i Oct 22, 2015
@acka47
Copy link
Contributor Author

acka47 commented Oct 23, 2015

Looks great from my side: +1 @jschnasse What do you think?

@dr0i dr0i assigned jschnasse and unassigned acka47 Oct 23, 2015
@jschnasse
Copy link

http://test.lobid.org/resource?author=36467-8 looks still wrong?

@dr0i
Copy link
Member

dr0i commented Oct 26, 2015

The test instance is automatically switched to the newest index which is build weekly at the weekend, not having the commit merged thus not having the new data in it.
I switched the index alias back to index which reflects the commit.
So, please review anew.

@jschnasse
Copy link

+1

@dr0i
Copy link
Member

dr0i commented Oct 26, 2015

Deployed to production, closing.

@dr0i dr0i closed this as completed Oct 26, 2015
@dr0i dr0i removed the review label Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants