Skip to content
This repository has been archived by the owner on Jun 23, 2020. It is now read-only.

For events as contributors/creators name is missing in label #735

Closed
acka47 opened this issue Oct 9, 2015 · 6 comments
Closed

For events as contributors/creators name is missing in label #735

acka47 opened this issue Oct 9, 2015 · 6 comments
Assignees
Labels

Comments

@acka47
Copy link
Contributor

acka47 commented Oct 9, 2015

Examples:

I imagine the approach above might make problems with some labels. Alternatives would be:

The problem obviously is that 200, subfield e isn't taken into account, see e.g. source for http://lobid.org/resource/HT018612706 (snippet):

<datafield ind2="1" ind1="b" tag="200">
            <subfield code="e">Art Cologne</subfield>
            <subfield code="n">49.</subfield>
            <subfield code="d">2015</subfield>
            <subfield code="c">Köln</subfield>
            <subfield code="9">(DE-588)1069643262</subfield>
</datafield>

...and for http://lobid.org/resource/HT018658394 (snippet):

<datafield ind2="1" ind1="b" tag="204">
            <subfield code="e">Private Equity Konferenz NRW</subfield>
            <subfield code="n">9.</subfield>
            <subfield code="d">2015</subfield>
            <subfield code="c">Düsseldorf</subfield>
            <subfield code="9">(DE-588)1071063812</subfield>
</datafield>
dr0i added a commit that referenced this issue Oct 15, 2015
If subfields 'n,e,d,c' of field 200 exist, concatenate them in this order.
If one of these subfields is missing, fall back to concatenate the subfields
in the order they appear.

See #735.

- adjust tests
@dr0i
Copy link
Member

dr0i commented Oct 16, 2015

Deployed to staging.

@dr0i dr0i assigned acka47 and unassigned dr0i Oct 16, 2015
@dr0i dr0i added review and removed working labels Oct 16, 2015
@acka47
Copy link
Contributor Author

acka47 commented Oct 16, 2015

This is better but not as I asked for. There is a comma that shouldn't be there.

It now reads "9., Private Equity Konferenz NRW, 2015, Düsseldorf" instead of "9. Private Equity Konferenz NRW, 2015, Düsseldorf" and "49., Art Cologne, 2015, Köln" instead of "49. Art Cologne, 2015, Köln".

@acka47 acka47 assigned dr0i and unassigned acka47 Oct 16, 2015
@acka47 acka47 added working and removed review labels Oct 16, 2015
dr0i added a commit that referenced this issue Oct 16, 2015
If subfields 'n,e,d,c' of field 200 exist, concatenate them in this order.
If one of these subfields is missing, fall back to concatenate the subfields
in the order they appear.

See #735.

- adjust tests
@dr0i dr0i added review and removed working labels Oct 16, 2015
@dr0i
Copy link
Member

dr0i commented Oct 16, 2015

Deployed to production, but not closing. The comma is removed in the config and that will be in the index on monday. Will then closing.

@dr0i dr0i added deploy and removed review labels Oct 16, 2015
@dr0i
Copy link
Member

dr0i commented Oct 19, 2015

Deployed to staging.

@dr0i dr0i removed their assignment Oct 19, 2015
@dr0i dr0i added review and removed deploy labels Oct 19, 2015
@acka47
Copy link
Contributor Author

acka47 commented Oct 19, 2015

+1 Please deploy to production. We will open another issue as soon as stakeholdes complain that the current pattern doesn't work with some events.

@acka47 acka47 assigned dr0i and unassigned acka47 Oct 19, 2015
@acka47 acka47 added deploy and removed review labels Oct 19, 2015
@dr0i
Copy link
Member

dr0i commented Oct 19, 2015

Deployed to production, closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants