Skip to content

Conversation

Ryzoo
Copy link
Contributor

@Ryzoo Ryzoo commented Mar 18, 2020

  • add possibility to focus search on start (default true)
  • update dependencies, only x.x.part to avoid conflicts and problem
  • update this library version

@Ryzoo Ryzoo changed the title Added possibility to focus search on start like, Added possibility to focus search on start. Mar 18, 2020
Copy link
Member

@harshzalavadiya harshzalavadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thank you for the PR,

  • can you please make suggested changes?
  • also it might be nice if you can add example prop mapping in storybook and add prop entry in docs otherwise I'll be happy to do it for you just let me know

@Ryzoo
Copy link
Contributor Author

Ryzoo commented Mar 19, 2020

Hi, I updated the code. I added the improvements you mentioned in the comment. I hope, now all is fine

@harshzalavadiya harshzalavadiya merged commit 3ab37c2 into hc-oss:master Mar 19, 2020
@harshzalavadiya
Copy link
Member

harshzalavadiya commented Mar 19, 2020

LGTM, released v1.3.3 thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants