Fix doubled libbacktrace dependency #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 24, 2023
|
/gcbrun |
|
Looks like this is related to the boost thing. |
Closed
lpawelcz
force-pushed
the
fix-libbacktrace-dep
branch
from
032e7b5
to
a08b097
Compare
This was referenced Jun 12, 2023
Merged
lpawelcz
force-pushed
the
fix-libbacktrace-dep
branch
from
a08b097
to
e51ffbf
Compare
lpawelcz
added a commit
to antmicro/xls
that referenced
this pull request
Jun 13, 2023
This is a temporary change to test the XLS workspace before PRs in bazel_rules_hdl are merged: * hdl/bazel_rules_hdl#167 * hdl/bazel_rules_hdl#164 * hdl/bazel_rules_hdl#165 Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
proppy
approved these changes
Jun 13, 2023
|
LGTM, but @QuantamHD needs to hit the merge button :) |
QuantamHD
approved these changes
Jun 13, 2023
lpawelcz
force-pushed
the
fix-libbacktrace-dep
branch
from
e51ffbf
to
3b3db71
Compare
libbacktrace.patch adds explicit bazel dependency on libbacktrace which manifests in compilation args as: '-Wl,-no-whole-archive bazel-out/k8-opt-exec-2B5CBBC6/bin/external/com_github_libbacktrace/liblibbacktrace.a' The patch does not remove '-lbacktrace' from linkopts which introduces second libbacktrace dependency, this time for OS-installed library. This commit fixes the patch. Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the third and the last one in PR chain that consists of:
Each of the following PRs depend on previous ones which means that the correct merging order is:
#167 -> #164 -> #165
I will rebase the PRs one at the time as they are merged in order to avoid conflicts.
This PR fixes #161.
libbacktrace.patchadds explicit bazel dependency onlibbacktracewhich manifests in compilation args as:The patch does not remove
-lbacktracefromlinkoptswhich introduces secondlibbacktracedependency, this time for OS-installed library. PR fixes the patch by removing unnecessary linker option.